The most efficient shape for withstanding high pressure is a sphere but that would be costly to manufacture. A cylinder with a domed top and a domed bottom (look underneath, the flat base is actually welded around the outside, the bottom of the gas container is actually domed) is a much cheaper shape to manufacture whilst still having good strength to resist the internal gas pressure.